Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support proxy-polyfill #41

Merged
merged 4 commits into from
Aug 13, 2022
Merged

feat: support proxy-polyfill #41

merged 4 commits into from
Aug 13, 2022

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jun 21, 2022

close #40

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 21, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 75f636c:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

@dai-shi dai-shi mentioned this pull request Jun 21, 2022
Closed
janjangao
janjangao approved these changes Jun 21, 2022
View reviewed changes
Copy link

@janjangao janjangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other changes I can't confirm, since I am also not very familiar with the whole project, but the replaceNewProxy function and relevant newProxy are look good to me. thanks again.

@dai-shi dai-shi mentioned this pull request Jun 21, 2022
Merged
@dai-shi
Copy link
Owner Author

dai-shi commented Jun 21, 2022

the other changes

In short, I used proxyHanlder previously to store some state, but it would break with proxy-polyfill, so refactored. If the final functionality isn't broken, it should be just good.

@dai-shi dai-shi merged commit e66e32e into main Aug 13, 2022
@dai-shi dai-shi deleted the feat/support-proxy-polyfill branch August 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janjangao janjangao janjangao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alternative of Proxy
2 participants
@dai-shi @janjangao