feat: pageprops type improvements with docs for use #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
Nov 12, 2024
docs/create-pages.mdx
Outdated
|
|
||
| ```tsx | ||
| // ./src/pages/about.tsx | ||
| import { PageProps } from 'waku/router/client'; |
There was a problem hiding this comment.
Importing "client" in the server file isn't very nice.
Hm, I think you meant this?
Suggested change
| import { PageProps } from 'waku/router/client'; | |
| import type { PageProps } from 'waku/router'; |
There was a problem hiding this comment.
Importing "client" in the server file isn't very nice.
hm I agree... could we export this from waku/router or somewhere else?
and yes good catch
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
happy to add this to more examples if we want to