Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to vite 4.5.0 #141

Merged
merged 5 commits into from
Oct 25, 2023
Merged

feat: upgrade to vite 4.5.0 #141

merged 5 commits into from
Oct 25, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Oct 23, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:06am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a4bfae7:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@dai-shi
Copy link
Owner

dai-shi commented Oct 24, 2023

Oh, nice. They backported it.
Let me merge my PR first.

@himself65
Copy link
Contributor Author

let me resolve the conflict

@himself65 himself65 force-pushed the himself65/bump branch 2 times, most recently from cfa5ef6 to 670a27c Compare October 24, 2023 00:07
@dai-shi
Copy link
Owner

dai-shi commented Oct 24, 2023

We have a hack to copy something for patch in the "template" script in packages/create-waku/package.json

dai-shi
dai-shi reviewed Oct 24, 2023
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to remove the postinstall script in waku/package.json.
(Oh this is so clean, eliminating all hacks I've done. 😄 )

packages/create-waku/package.json Show resolved Hide resolved
@himself65
Copy link
Contributor Author

I squash it to 3 commits to help the rebase merge

dai-shi
dai-shi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

I will "squash and merge" anyway.

@dai-shi dai-shi changed the title chore: bump vite version feat: upgrade to vite 4.5.0 Oct 25, 2023
@dai-shi
Copy link
Owner

dai-shi commented Oct 25, 2023

oops, i failed to resolve conflicts correctly. thanks.

@dai-shi dai-shi merged commit c2b3df2 into dai-shi:main Oct 25, 2023
3 checks passed
@himself65 himself65 deleted the himself65/bump branch October 25, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himself65 @dai-shi