feat(router): createPages #293

dai-shi · 2023-12-19T07:25:57Z

Close #246

vercel · 2023-12-19T07:26:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	Dec 25, 2023 0:12am

codesandbox-ci · 2023-12-19T07:26:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72f617d:

Sandbox	Source
Vanilla Typescript	Configuration
React	Configuration
React TypeScript	Configuration

Aslemammad · 2023-12-19T20:21:15Z

Why not the traditional file-based routing? Just curious.

dai-shi · 2023-12-20T02:46:35Z

config-based router matches better for non-node env and for vite/rollup limitation.
We (including third-party library authors) can create a file-based router too.

himself65 · 2023-12-23T04:47:43Z

chunk-43D56K65.js?v=0b716eb3:517 Warning: Expected server HTML to contain a matching <div> in <body>.
    at div
    at Slot (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:85:24)
    at Children (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:98:29)
    at Slot (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:85:24)
    at InnerRouter (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/router/client.js:93:24)
    at Root (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/client.js:65:24)
    at Router (http://localhost:3000/@fs/C:/Users/himse/Code/waku/packages/waku/dist/router/client.js:187:26)
    at ErrorBoundaryClass (http://localhost:3000/src/components/ErrorBoundary.tsx:4:5)
printWarning @ chunk-43D56K65.js?v=0b716eb3:517
Show 1 more frame
Show less
chunk-43D56K65.js?v=0b716eb3:5811 Uncaught Error: Hydration failed because the initial UI does not match what was rendered on the server.
    at throwOnHydrationMismatch (chunk-43D56K65.js?v=0b716eb3:5811:17)
    at tryToClaimNextHydratableInstance (chunk-43D56K65.js?v=0b716eb3:5847:15)
    at updateHostComponent$1 (chunk-43D56K65.js?v=0b716eb3:12330:13)
    at beginWork$1 (chunk-43D56K65.js?v=0b716eb3:13544:22)
    at HTMLUnknownElement.callCallback2 (chunk-43D56K65.js?v=0b716eb3:14856:22)
    at Object.invokeGuardedCallbackImpl (chunk-43D56K65.js?v=0b716eb3:14881:24)
    at invokeGuardedCallback (chunk-43D56K65.js?v=0b716eb3:14921:37)
    at beginWork (chunk-43D56K65.js?v=0b716eb3:18955:15)
    at performUnitOfWork (chunk-43D56K65.js?v=0b716eb3:18240:20)
    at workLoopSync (chunk-43D56K65.js?v=0b716eb3:18066:13)
chunk-43D56K65.js?v=0b716eb3:517 Warning: An error occurred during hydration. The server HTML was replaced with client content in <body>.
printWarning @ chunk-43D56K65.js?v=0b716eb3:517
Show 1 more frame
Show less
chunk-43D56K65.js?v=0b716eb3:17611 Uncaught Error: Unknown root exit status.
    at finishConcurrentRender (chunk-43D56K65.js?v=0b716eb3:17611:21)
    at performConcurrentWorkOnRoot (chunk-43D56K65.js?v=0b716eb3:17552:17)
    at workLoop (chunk-43D56K65.js?v=0b716eb3:191:42)
    at flushWork (chunk-43D56K65.js?v=0b716eb3:170:22)

dai-shi · 2023-12-23T04:50:18Z

Thanks.

Why hydration mismatch only on windows...

himself65

Subject: [PATCH] fix: add suspense
---
Index: packages/waku/src/router/client.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/packages/waku/src/router/client.ts b/packages/waku/src/router/client.ts
--- a/packages/waku/src/router/client.ts	(revision 7d50ea37986f14e884897c1af0e156db40bb824d)
+++ b/packages/waku/src/router/client.ts	(date 1703307050084)
@@ -10,6 +10,7 @@
   useState,
   useTransition,
   Fragment,
+  Suspense,
 } from 'react';
 import type { ComponentProps, FunctionComponent, ReactNode } from 'react';
 
@@ -224,13 +225,17 @@
   );
 
   return createElement(
-    Fragment,
-    null,
-    createElement(Slot, { id: SHOULD_SKIP_ID }),
-    createElement(
-      RouterContext.Provider,
-      { value: { loc, changeLocation, prefetchLocation } },
-      children,
+    Suspense,
+    null,
+    createElement(
+      Fragment,
+      null,
+      createElement(Slot, { id: SHOULD_SKIP_ID }),
+      createElement(
+        RouterContext.Provider,
+        { value: { loc, changeLocation, prefetchLocation } },
+        children,
+      ),
     ),
   );
 }

himself65 · 2023-12-23T04:54:34Z

Subject: [PATCH] fix: add suspense
---
Index: packages/waku/src/router/client.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/packages/waku/src/router/client.ts b/packages/waku/src/router/client.ts
--- a/packages/waku/src/router/client.ts	(revision 7d50ea37986f14e884897c1af0e156db40bb824d)
+++ b/packages/waku/src/router/client.ts	(date 1703307050084)
@@ -10,6 +10,7 @@
   useState,
   useTransition,
   Fragment,
+  Suspense,
 } from 'react';
 import type { ComponentProps, FunctionComponent, ReactNode } from 'react';
 
@@ -224,13 +225,17 @@
   );
 
   return createElement(
-    Fragment,
-    null,
-    createElement(Slot, { id: SHOULD_SKIP_ID }),
-    createElement(
-      RouterContext.Provider,
-      { value: { loc, changeLocation, prefetchLocation } },
-      children,
+    Suspense,
+    null,
+    createElement(
+      Fragment,
+      null,
+      createElement(Slot, { id: SHOULD_SKIP_ID }),
+      createElement(
+        RouterContext.Provider,
+        { value: { loc, changeLocation, prefetchLocation } },
+        children,
+      ),
     ),
   );
 }

This will fix, but hydration error still

This reverts commit f32fe55.

dai-shi · 2023-12-25T12:11:19Z

btw, I don't know how the windows CI failing issue was resolved.

dai-shi added 2 commits December 19, 2023 15:51

wip: createPages for static path

e665e00

wip: createPages from waku/router

53c834f

dai-shi changed the title ~~feat(router): createPage~~ feat(router): createPages Dec 19, 2023

dai-shi added 2 commits December 19, 2023 19:26

Merge branch 'main' into feat/router/create-pages

ba8fea1

support createLayout

e4d9ba1

vercel bot deployed to Preview December 19, 2023 11:52 View deployment

dai-shi mentioned this pull request Dec 19, 2023

update README for v0.19.0 #296

Closed

dai-shi added 3 commits December 23, 2023 10:16

Merge branch 'main' into feat/router/create-pages

cc7e133

move files

2734fb6

wip: new createPages api

7d50ea3

vercel bot deployed to Preview December 23, 2023 04:18 View deployment

himself65 suggested changes Dec 23, 2023

View reviewed changes

dai-shi added 2 commits December 23, 2023 15:41

Merge branch 'main' into feat/router/create-pages

5914469

rewrite types with adding eslint rule

b38eba0

vercel bot deployed to Preview December 23, 2023 07:58 View deployment

fix typing

c819d6f

vercel bot deployed to Preview December 23, 2023 10:57 View deployment

Merge branch 'main' into feat/router/create-pages

8668294

vercel bot deployed to Preview December 23, 2023 12:34 View deployment

avoid lazy

f32fe55

vercel bot deployed to Preview December 23, 2023 12:58 View deployment

Revert "avoid lazy"

4881d60

This reverts commit f32fe55.

vercel bot deployed to Preview December 23, 2023 13:16 View deployment

Merge branch 'main' into feat/router/create-pages

af02705

vercel bot deployed to Preview December 23, 2023 22:19 View deployment

dai-shi added 2 commits December 25, 2023 13:30

Merge branch 'main' into feat/router/create-pages

46c7b80

fix some issues in createPages

083cf78

vercel bot deployed to Preview December 25, 2023 04:51 View deployment

dai-shi added 2 commits December 25, 2023 15:14

wip: implement dynamic route

e7051a3

dynamic render

9d83c15

dai-shi marked this pull request as ready for review December 25, 2023 06:43

vercel bot deployed to Preview December 25, 2023 06:44 View deployment

fix wildcard

6d24037

vercel bot deployed to Preview December 25, 2023 06:56 View deployment

fix various bugs

621169f

vercel bot deployed to Preview December 25, 2023 11:24 View deployment

improve types

3db7ae2

vercel bot deployed to Preview December 25, 2023 11:57 View deployment

dai-shi mentioned this pull request Dec 25, 2023

experimental: add another router example #118

Closed

update CHANGELOG

72f617d

vercel bot deployed to Preview December 25, 2023 12:12 View deployment

dai-shi merged commit 38405ba into main Dec 25, 2023
27 checks passed

dai-shi deleted the feat/router/create-pages branch December 25, 2023 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(router): createPages #293

feat(router): createPages #293

dai-shi commented Dec 19, 2023

vercel bot commented Dec 19, 2023 •

edited

Loading

codesandbox-ci bot commented Dec 19, 2023 •

edited

Loading

Aslemammad commented Dec 19, 2023

dai-shi commented Dec 20, 2023

himself65 commented Dec 23, 2023

dai-shi commented Dec 23, 2023

himself65 left a comment

himself65 commented Dec 23, 2023

dai-shi commented Dec 25, 2023

feat(router): createPages #293

feat(router): createPages #293

Conversation

dai-shi commented Dec 19, 2023

vercel bot commented Dec 19, 2023 • edited Loading

codesandbox-ci bot commented Dec 19, 2023 • edited Loading

Aslemammad commented Dec 19, 2023

dai-shi commented Dec 20, 2023

himself65 commented Dec 23, 2023

dai-shi commented Dec 23, 2023

himself65 left a comment

Choose a reason for hiding this comment

himself65 commented Dec 23, 2023

dai-shi commented Dec 25, 2023

vercel bot commented Dec 19, 2023 •

edited

Loading

codesandbox-ci bot commented Dec 19, 2023 •

edited

Loading