Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: environment variables #321

Merged
merged 15 commits into from
Jan 1, 2024
Merged

feat: environment variables #321

merged 15 commits into from
Jan 1, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 26, 2023 •
edited
Loading

close #292

  • core
  • website
  • .env.local

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 1, 2024 4:35am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 26, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42187d3:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 27, 2023

I thought about using import.meta.env like Vite (and maybe use Vite feature), but it may not work well with server components. Thus, a global variable. We may revisit before v1.

Also, thought about using dotenv, but it's a naive one for now. We can consider depending on dotenv for more capabilities.

@dai-shi dai-shi marked this pull request as ready for review December 27, 2023 01:26
himself65
himself65 reviewed Dec 27, 2023
View reviewed changes
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-use exsitingreact api?

https://react.dev/reference/react/experimental_taintUniqueValue

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 27, 2023

We can use it for safety when it's in canary.

@himself65
Copy link
Contributor

I found a related vite issue:

vitejs/vite#9171

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 31, 2023

I was wondering if we could avoid optimized deps changes from the ground.

@dai-shi
Revert "does this pass?"
f34d992 
This reverts commit 31a83a7.
dai-shi
dai-shi commented Jan 1, 2024
View reviewed changes
Copy link
Owner Author

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good.

@himself65
Copy link
Contributor

How you do that

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 1, 2024

reviewed the breaking commit dbc3d29 and reverted some changes, and applied a new approach.

@dai-shi dai-shi merged commit d42ce3c into main Jan 1, 2024
28 checks passed
@dai-shi dai-shi deleted the feat/env-vars branch January 1, 2024 04:52
ojj1123 added a commit to ojj1123/info that referenced this pull request Jan 14, 2024
@ojj1123
fix: remove __WAKU_SSR_ENNABLED__
e5e27df 
- see dai-shi/waku#321
@ojj1123 ojj1123 mentioned this pull request Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

environment variables improvement
2 participants
@dai-shi @himself65