step 3 for middleware architecture #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
himself65
reviewed
Mar 2, 2024
himself65
suggested changes
Mar 2, 2024
There was a problem hiding this comment.
Subject: [PATCH] fix
---
Index: e2e/fixtures/rsc-basic/tsconfig.config.json
===================================================================
diff --git a/e2e/fixtures/rsc-basic/tsconfig.config.json b/e2e/fixtures/rsc-basic/tsconfig.config.json
deleted file mode 100644
--- a/e2e/fixtures/rsc-basic/tsconfig.config.json (revision 29c465342cef32a272d0cb3228d5505d37e4b49f)
+++ /dev/null (revision 29c465342cef32a272d0cb3228d5505d37e4b49f)
@@ -1,7 +0,0 @@
-{
- "extends": "./tsconfig.json",
- "compilerOptions": {
- "outDir": "./dist/config"
- },
- "include": ["waku.config.ts"]
-}
Index: e2e/fixtures/rsc-basic/tsconfig.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/e2e/fixtures/rsc-basic/tsconfig.json b/e2e/fixtures/rsc-basic/tsconfig.json
--- a/e2e/fixtures/rsc-basic/tsconfig.json (revision 29c465342cef32a272d0cb3228d5505d37e4b49f)
+++ b/e2e/fixtures/rsc-basic/tsconfig.json (date 1709342708116)
@@ -13,10 +13,5 @@
"outDir": "./dist",
"composite": true
},
- "include": ["./src"],
- "references": [
- {
- "path": "./tsconfig.config.json"
- }
- ]
+ "include": ["./src", "./waku.config.ts"]
}
|
I believe this is a vite related issue, let me check where it comes from |
|
OHHH, related: vitejs/vite#15870 |
|
#557 (comment) fixes it. pretty interesting. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
commented
Mar 3, 2024
This reverts commit 77854a8.
dai-shi
commented
Mar 3, 2024
| * import('waku/middleware/rsc'), | ||
| * ] | ||
| */ | ||
| middleware?: (cmd: 'dev' | 'start') => Promise<{ default: Middleware }>[]; |
There was a problem hiding this comment.
Is it better to do loadMiddleware: (cmd) => Promise<Middleware[]>?
dai-shi
commented
Mar 3, 2024
| @@ -18,7 +18,7 @@ | |||
| "react": "18.3.0-canary-6c3b8dbfe-20240226", | |||
| "react-dom": "18.3.0-canary-6c3b8dbfe-20240226", | |||
| "react-server-dom-webpack": "18.3.0-canary-6c3b8dbfe-20240226", | |||
| "waku": "https://pkg.csb.dev/dai-shi/waku/commit/07b708cd/waku" | |||
| "waku": "workspace:*" | |||
There was a problem hiding this comment.
We'll go back to csb version later, or maybe "file" one.
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step 3 for #513 following #545 and #550