-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop sending ssr hydrate flag when the --with-ssr
flag is absent
#567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
--with-ssr
flag is absent
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
That's kind of intentional. Can you help me understand the problem? How can I reproduce the bug? |
I see, well, in #552 the error is hydration error while withSSR is false. Another way to reproduce it is to put a console log in one main.tsx files, in the first condition (when the dataset.hydrate is true). And when running the project, remove the --with-ssr flag. At that point, we still hydrate and it will show the log. If it's intentional, then for the 07_router ci test we need to consider another solution or remove the test completely since as it was commented there, the test was not supposed to work with ssr in standalone mode. |
After #565 is merged, is the test breaking? sorry, if I miss some points. |
I haven't tried that PR yet, so let me try it and let you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test was not supposed to work with ssr in standalone mode.
let's remove it.
Probably easier to create a new PR. |
While working on #552
I found out that the ci was giving hydration error while the withSSR was false. The reason was that
data-hydrate
was always true.