Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deploy): vercel serve and constants #877

Merged
merged 6 commits into from
Sep 14, 2024
Merged

refactor(deploy): vercel serve and constants #877

merged 6 commits into from
Sep 14, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Sep 14, 2024 •
edited
Loading

following #866

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Sep 14, 2024 8:38am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 14, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review September 14, 2024 07:19
tylersayshi
tylersayshi reviewed Sep 14, 2024
View reviewed changes
packages/waku/package.json Outdated
@@ -34,6 +34,10 @@
"types": "./dist/internals.d.ts",
"default": "./dist/internals.js"
},
"./hono": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious here, but why do /hono and /internals need to be in the published package json exports if they are for internal use only?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it at first (locally without commits), but it feels like mixed. /internals are "more internal" than /hono, so to speak. 😄
In any case, I might be reconsidering it in the future, before finalizing v1.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I noticed we need to re-export Hono to avoid adding in peer dependencies. So, /internals are weird for it.

Copy link
Owner Author

@dai-shi dai-shi Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood your question probably.

  • /internals are for someone who might want to experiment something (hypothetical use case).
  • /hono is for deploy plugins (actual use case), and I wish this could be avoided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes more sense! Thanks for the explanation

package.json Outdated
@@ -51,7 +51,7 @@
"examples:prd:24_nesting": "NAME=24_nesting pnpm run examples:prd",
"website:dev": "(cd packages/website && pnpm run dev)",
"website:build": "cd packages/website && pnpm run build",
"website:vercel": "pnpm run compile && pnpm run website:build --with-vercel-static && mv packages/website/.vercel/output .vercel/",
"website:vercel": "pnpm run compile && pnpm run website:build && mv packages/website/.vercel/output .vercel/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to test the hono server serving the website from vercel?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks 👍

@dai-shi dai-shi merged commit 52973c8 into main Sep 14, 2024
28 checks passed
@dai-shi dai-shi deleted the refactor/deploy/vercel branch September 14, 2024 09:22
@dai-shi dai-shi mentioned this pull request Sep 15, 2024
Merged
dai-shi added a commit that referenced this pull request Sep 15, 2024
@dai-shi
refactor(build): netlify serve (#878)
9ca5161 
following #877
This was referenced Sep 15, 2024
Merged
Merged
Merged
Merged
@dai-shi dai-shi changed the title refactor(build): vercel serve and constants refactor(deploy): vercel serve and constants Sep 15, 2024
@dai-shi dai-shi mentioned this pull request Sep 16, 2024
Open
89 tasks
dai-shi added a commit that referenced this pull request Sep 16, 2024
@dai-shi
refactor(deploy): deno serve (#880)
ebae041 
Prior art:
- #877 
- #878
dai-shi added a commit that referenced this pull request Sep 19, 2024
@dai-shi @rmarscher
refactor(deploy): cloudflare serve (#879)
543da2a 
Prior art:
- #877 
- #878

---------

Co-authored-by: Rob Marscher <rob@robmarscher.com>
dai-shi added a commit that referenced this pull request Sep 27, 2024
@dai-shi
refactor(deploy): aws-lambda serve (#882)
abc5d17 
Prior art:
- #877 
- #878
dai-shi added a commit that referenced this pull request Oct 1, 2024
@dai-shi
refactor(deploy): partykit serve (#881)
0b0fc9b 
Prior art:
- #877 
- #878 
- and many other follow-up PRs (already merged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersayshi tylersayshi tylersayshi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dai-shi @tylersayshi