Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): new_defineEntries #993

Merged
merged 6 commits into from
Nov 9, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Nov 8, 2024

Migrating examples:

  • 38_cookies
  • 39_api
  • 35_nesting

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:10am

Copy link

codesandbox-ci bot commented Nov 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner Author

dai-shi commented Nov 8, 2024

Hmmmm, now I'm wondering if calling unstable_handleRequest at the build time is a good idea or not.

But, we want to make buildConfig serializable. 🤔

@dai-shi dai-shi marked this pull request as ready for review November 8, 2024 12:10
@dai-shi dai-shi merged commit b883c4a into main Nov 9, 2024
26 checks passed
@dai-shi dai-shi deleted the chore/examples/new-define-entries branch November 9, 2024 01:57
dai-shi added a commit that referenced this pull request Nov 19, 2024
following up #993.

- [x] 32_minimal_js
- [x] 33_promise
- [x] 36_form
- [x] 37_css
- [x] 41_path-alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant