Skip to content

Get fingerprint data from python package#29

Merged
daijro merged 2 commits intodaijro:mainfrom
Pijukatel:fingerprint-data-from-package
Mar 20, 2025
Merged

Get fingerprint data from python package#29
daijro merged 2 commits intodaijro:mainfrom
Pijukatel:fingerprint-data-from-package

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Mar 10, 2025

Hi,

I created this new Python repository which contains fingerprint datapoints.
It uses datapoints from the apify/fingerprint_suite, so we will keep it updated.
Repo is super simple, just data files + 5 helpers

Motivation:
Remove the necessity to download additional files and avoid potential issues like this: #26

Deterministic results - specific version of browserforge will always use same data files. Previously that would depend on what data files were downloaded.

Simpler setup.

Open question
Deprecation process? I replaced those download related functions with dummy implementation and I was thinking that once I remove any dependency from camoufox repo I could delete them completely. Is that ok?

apify-fingerprint-datapoints version constraint? Is it preferable to take latest, or is it preferable to have manual control and bump the version dependency manually?

Version bump? Should be be minor version bump once the deprecated functions are deleted?

@Pijukatel Pijukatel marked this pull request as ready for review March 10, 2025 09:55
@Pijukatel
Copy link
Contributor Author

Hi @daijro,

Would you please consider this change to browserforge ?

@juanfrilla
Copy link

thanks so much @deedy5 , let's see what @daijro says

@daijro
Copy link
Owner

daijro commented Mar 20, 2025

Hello,

Sorry for the delay, I've been out of town for the last week. I just looked through the changes, and they lgtm!

Although, I may add back dummy update and remove CLI options before the next release to provide a depreciation notice for those relying on them within existing scripts.


To anyone reading this worried about the source of this new package providing the data sets, they're pulled directly from the Apify repo & published using a GH action:
apify/fingerprint-suite@344a7d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants