Get fingerprint data from python package#29
Merged
daijro merged 2 commits intodaijro:mainfrom Mar 20, 2025
Merged
Conversation
Contributor
Author
|
Hi @daijro, Would you please consider this change to browserforge ? |
This was referenced Mar 10, 2025
Owner
|
Hello, Sorry for the delay, I've been out of town for the last week. I just looked through the changes, and they lgtm! Although, I may add back dummy To anyone reading this worried about the source of this new package providing the data sets, they're pulled directly from the Apify repo & published using a GH action: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I created this new Python repository which contains fingerprint datapoints.
It uses datapoints from the apify/fingerprint_suite, so we will keep it updated.
Repo is super simple, just data files + 5 helpers
Motivation:
Remove the necessity to download additional files and avoid potential issues like this: #26
Deterministic results - specific version of browserforge will always use same data files. Previously that would depend on what data files were downloaded.
Simpler setup.
Open question
Deprecation process? I replaced those download related functions with dummy implementation and I was thinking that once I remove any dependency from camoufox repo I could delete them completely. Is that ok?
apify-fingerprint-datapoints version constraint? Is it preferable to take latest, or is it preferable to have manual control and bump the version dependency manually?
Version bump? Should be be minor version bump once the deprecated functions are deleted?