Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Find index match count #546

Closed
Crunchbits opened this issue Apr 15, 2024 · 1 comment · Fixed by #572
Closed

[Feature request] Find index match count #546

Crunchbits opened this issue Apr 15, 2024 · 1 comment · Fixed by #572

Comments

@Crunchbits
Copy link

Text in the Quick Find and potentially the Find Window that shows the index match count. That is to say it will show both the total matches and the current match number.

For example, it may show up as something like "3 of 9 matches" or "Found next match [3/9]".

Also potentially have a setting to only enable this feature for text files under custom set number of lines/characters (assuming this would help prevent slow down on big files).

@dail8859
Copy link
Owner

Definitely a good idea. I use this kind of feature alot when searching in a web browser :)

Also potentially have a setting to only enable this feature for text files under custom set number of lines/characters (assuming this would help prevent slow down on big files).

Yeah this is the key part of it -- because at a minimum it will have to search the entire document once to get an index and total count. As long as it is not edited then the total count and index could be cached.

dail8859 added a commit that referenced this issue Jun 14, 2024
This also overhauls the internals a bit and caches all the locations (since it highlights them anyways) and just uses that list to navigate. In theory the document shouldn't change while the QuickFindWidget is opened, meaning the cached search results will always be valid. Closes #546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants