Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Azure ServiceBus package #559

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

feat: Azure ServiceBus package #559

wants to merge 1 commit into from

Conversation

samtrion
Copy link
Member

Closes: #41

@samtrion samtrion added state:onhold Indicates that the work item is currently paused and not actively being worked on. type:feature Indicates a new feature or enhancement to be added. labels Dec 17, 2024
@samtrion samtrion self-assigned this Dec 17, 2024
@samtrion samtrion requested a review from a team as a code owner December 17, 2024 07:12
@samtrion samtrion requested review from benwirren and removed request for a team December 17, 2024 07:12
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.08943% with 70 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (3dae107) to head (64932a5).

Files with missing lines Patch % Lines
...ve.HealthChecks.Azure.ServiceBus/ClientCreation.cs 23.80% 32 Missing ⚠️
...re.ServiceBus/ServiceBusSubscriptionHealthCheck.cs 8.69% 21 Missing ⚠️
...cks.Azure.ServiceBus/ServiceBusTopicHealthCheck.cs 0.00% 8 Missing ⚠️
....Azure.ServiceBus/ServiceBusSubscriptionOptions.cs 0.00% 3 Missing ⚠️
...thChecks.Azure.ServiceBus/ServiceBusOptionsBase.cs 50.00% 2 Missing ⚠️
....Azure.ServiceBus/DependencyInjectionExtensions.cs 94.44% 1 Missing ⚠️
...cks.Azure.ServiceBus/ServiceBusQueueHealthCheck.cs 94.73% 1 Missing ⚠️
...zure.ServiceBus/ServiceBusQueueOptionsConfigure.cs 66.66% 1 Missing ⚠️
...hChecks.Azure.ServiceBus/ServiceBusTopicOptions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   98.63%   94.52%   -4.12%     
==========================================
  Files          79       89      +10     
  Lines        1539     1662     +123     
  Branches      252      267      +15     
==========================================
+ Hits         1518     1571      +53     
- Misses         21       91      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samtrion samtrion force-pushed the feature/azure-servicebus branch from 39c312d to 64932a5 Compare December 17, 2024 10:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@samtrion samtrion force-pushed the feature/azure-servicebus branch 2 times, most recently from d44a53a to bf75574 Compare December 17, 2024 20:31
@samtrion samtrion marked this pull request as draft December 19, 2024 06:20
@samtrion samtrion force-pushed the feature/azure-servicebus branch from bf75574 to d5ebdf0 Compare December 19, 2024 08:42
@samtrion samtrion changed the base branch from main to development December 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwirren benwirren Awaiting requested review from benwirren benwirren is a code owner automatically assigned from dailydevops/dotnet

Assignees

@samtrion samtrion

Labels
state:onhold Indicates that the work item is currently paused and not actively being worked on. type:feature Indicates a new feature or enhancement to be added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetEvolve.HealthChecks.Azure.ServiceBus
1 participant
@samtrion