Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Code cleanups #572

Merged
merged 3 commits into from
Dec 19, 2024
Merged

chore: Code cleanups #572

merged 3 commits into from
Dec 19, 2024

Conversation

samtrion
Copy link
Member

No description provided.

@samtrion samtrion added state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done. labels Dec 19, 2024
@samtrion samtrion self-assigned this Dec 19, 2024
@samtrion samtrion requested a review from a team as a code owner December 19, 2024 06:06
@samtrion samtrion requested review from Dakraid and removed request for a team December 19, 2024 06:06
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (12f287a) to head (2450b32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   98.63%   98.63%   -0.01%     
==========================================
  Files          79       79              
  Lines        1539     1536       -3     
  Branches      252      252              
==========================================
- Hits         1518     1515       -3     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samtrion samtrion merged commit 7f799e4 into main Dec 19, 2024
7 checks passed
@samtrion samtrion deleted the chore/code-cleanup branch December 19, 2024 06:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant