Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Use of configration and registration refactored #77

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

samtrion
Copy link
Member

@samtrion samtrion commented Oct 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #77 (ae9be4d) into main (9edec68) will decrease coverage by 14.49%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main      #77       +/-   ##
===========================================
- Coverage   98.98%   84.49%   -14.49%     
===========================================
  Files          35       35               
  Lines         394      387        -7     
  Branches       72       72               
===========================================
- Hits          390      327       -63     
- Misses          3       51       +48     
- Partials        1        9        +8     
Files Coverage Δ
...s.MySql.Connector/DependencyInjectionExtensions.cs 88.23% <66.66%> (-11.77%) ⬇️
...lve.HealthChecks.MySql.Connector/MySqlConfigure.cs 89.47% <0.00%> (-10.53%) ⬇️
...ealthChecks.MySql/DependencyInjectionExtensions.cs 88.23% <66.66%> (-11.77%) ⬇️
...src/NetEvolve.HealthChecks.MySql/MySqlConfigure.cs 89.47% <0.00%> (-10.53%) ⬇️
...althChecks.Npgsql/DependencyInjectionExtensions.cs 88.23% <66.66%> (-11.77%) ⬇️
...c/NetEvolve.HealthChecks.Npgsql/NpgsqlConfigure.cs 89.47% <0.00%> (-10.53%) ⬇️
...althChecks.Oracle/DependencyInjectionExtensions.cs 88.23% <66.66%> (-11.77%) ⬇️
...c/NetEvolve.HealthChecks.Oracle/OracleConfigure.cs 89.47% <0.00%> (-10.53%) ⬇️
...althChecks.SQLite/DependencyInjectionExtensions.cs 88.23% <66.66%> (-11.77%) ⬇️
...c/NetEvolve.HealthChecks.SQLite/SQLiteConfigure.cs 89.47% <0.00%> (-10.53%) ⬇️
... and 4 more

... and 8 files with indirect coverage changes

@samtrion samtrion marked this pull request as ready for review October 9, 2023 22:00
@samtrion samtrion requested review from a team and Dakraid and removed request for a team October 9, 2023 22:00
@samtrion samtrion self-assigned this Oct 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
11.4% 11.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@samtrion samtrion merged commit 229470a into main Oct 9, 2023
11 of 14 checks passed
@samtrion samtrion deleted the feature/cleanup-configuration branch October 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant