Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in Snappy.determineSnappyInputStream #34

Closed
jeffxi opened this issue Jul 15, 2016 · 1 comment
Closed

Exception in Snappy.determineSnappyInputStream #34

jeffxi opened this issue Jul 15, 2016 · 1 comment

Comments

@jeffxi
Copy link

jeffxi commented Jul 15, 2016

in version 0.4, Snappy.Java line 62.

if (read != STREAM_HEADER.length || read != HEADER_BYTES.length) {
throw new IllegalArgumentException("invalid header");
}

Is the logic valid? The condition will always be false so I always get an exception.

Should it be:

if (read != STREAM_HEADER.length && read != HEADER_BYTES.length) {
throw new IllegalArgumentException("invalid header");
}

@dain
Copy link
Owner

dain commented Jul 15, 2016

Ya that is totally wrong. We have moved future development to https://github.com/airlift/aircompressor

But I'll fix this here also

dmlap added a commit to dmlap/snappy that referenced this issue Mar 6, 2017
Based on dain's comment in dain#34, note that this project has been obsoleted by aircompressor.
dain pushed a commit that referenced this issue Sep 11, 2023
Based on dain's comment in #34, note that this project has been obsoleted by aircompressor.
@dain dain closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants