Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessModeSufficient value check is broken, as the metadata accepts a list of values #238

Closed
rdeltour opened this issue Jul 5, 2019 · 9 comments
Assignees
Labels
Milestone

Comments

@rdeltour
Copy link
Member

rdeltour commented Jul 5, 2019

Reported by @garconvacher:

The following markup:

<meta property="schema:accessModeSufficient">textual,visual</meta>

will be reported as:

metadata-accessmodesufficient-invalid (Moderate) : 'schema:accessModeSufficient' metadata must be set to one of the expected values
@rdeltour rdeltour self-assigned this Jul 5, 2019
@rdeltour rdeltour added the bug label Jul 5, 2019
@rdeltour rdeltour added this to the v1.1.1 milestone Jul 5, 2019
@laudrain
Copy link

laudrain commented Jul 5, 2019

@rdeltour knowledge base propose also with a space separator:
<meta property="accessModeSufficient" content="textual visual"/>
(http://kb.daisy.org/publishing/docs/metadata/schema-org.html)
Ace 1.1 reports is as an error also !

@mattgarrish
Copy link

EPUB can't represent the expected ItemList defined in schema.org, so this is one of the cases where we had to come up with a workaround.

Both tend to be acceptable, and we should probably be permissive from a validation standpoint. The KB actually mixes both, as the full example uses commas but the individual definition does not. (I have a memory that we decided to use commas somewhere near the end of the a11y spec revision just to make clear that there was a list as the value, but it's not an enforced requirement in any document.)

@mattgarrish
Copy link

mattgarrish commented Jul 5, 2019

Skimming the techniques document, we did put this statement in:

The order in which the access modes are listed is not important. The only requirement is that they be separated by commas.

http://www.idpf.org/epub/a11y/techniques/#meta-002

It's not a normative document, though, so "requirement" here is just a descriptive statement of what we were expecting.

garconvacher pushed a commit to garconvacher/Blitz that referenced this issue Jul 8, 2019
Ace reports violations but it does not matter:
- `accessibilityApi` as invalid because only `ARIA` is allowed
- `accessModeSufficient` as invalid for a list of values (issue: daisy/ace#238)
- `accessibilityFeature="printPageNumbers"` because there's no `<nav epub:type="page-list">`
@laudrain
Copy link

Sorry but I don't see the resolution of this issue !

Should we remove:
<meta property="schema:accessModeSufficient">textual,visual</meta>
?

@rdeltour
Copy link
Member Author

@laudrain have you updated to v1.1.1? (released on Monday July 8)

@laudrain
Copy link

Ah yes, thanks. I'll do it immediately

@laudrain
Copy link

Perfect, no more issue in 1.1.1!

@laudrain
Copy link

@rdeltour ace --version still gives 1.1.0

@rdeltour
Copy link
Member Author

@rdeltour ace --version still gives 1.1.0

yes, I realized that yesterday, with feedback from @clapierre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants