fix an issue with extra space in unified diff #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
force-pushed
the
fix-extra-space
branch
from
1988e81
to
10388ef
Compare
The GetUnifiedDiffString returns all lines with an extra character at beginning of each line: `+`, `-`, ` ` (space). The code properly handled the `+` and `-`, but not handled ` ` (space) character at all. So all changed code got an additional space at the beginning of each line. This change fixes the issue. Issue is not critical, because simple `go fmt` removes that space and this is the reason I didn't catch it earlier. Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
SVilgelm
force-pushed
the
fix-extra-space
branch
from
10388ef
to
a4b3b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetUnifiedDiffString returns all lines with an extra character at beginning of each line:
+,-,The code properly handled the
+and-, but not handledSo all changed code got an additional space at the beginning of each line.
This change fixes the issue.
Issue is not critical, because simple
go fmtremoves that space and this is the reason I didn't catch it earlier.