Fix build with mysql-connector-c v8.0.18 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes following compilation failure with version 8.0.18 of
mysql-connector-c:
```
rdf_storage_mysql.c: In function 'librdf_storage_mysql_get_handle':
rdf_storage_mysql.c:450:5: error: unknown type name 'my_bool'; did you mean 'bool'?
450 | my_bool value=(context->reconnect) ? 1 : 0;
| ^~~~~~~
| bool
make[3]: *** [Makefile:886: librdf_storage_mysql_la-rdf_storage_mysql.lo] Error 1
```
The correct type for calling `mysql_options` with `MYSQL_OPT_RECONNECT`
in version 8.0 of the library is `bool*`:
https://dev.mysql.com/doc/refman/8.0/en/mysql-options.html
See-Also: https://bugs.gentoo.org/692462
devurandom
added a commit
to devurandom/gentoo-patches
that referenced
this pull request
Oct 19, 2019
|
I don’t think you can simply replace it like that, because the code must work with mysql-connector-c version 6 and version 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes following compilation failure with version 8.0.18 of
mysql-connector-c:
The correct type for calling
mysql_optionswithMYSQL_OPT_RECONNECTin version 8.0 of the library is
bool*:https://dev.mysql.com/doc/refman/8.0/en/mysql-options.html
See-Also: https://bugs.gentoo.org/692462