Feature/kthreads #446
Merged
Feature/kthreads #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output of tools like ps usually put square brackets around kernel threads to easily distinguish those from userspace processes
by default the output is unchanged, but this option allows the user to hide kernel threads
|
Looks good! [display]
show_kthreads = falseHow about it? |
|
I think it depends on how often you want to switch between the two options (with and without kthreads). If most of the time users are not interested in kthreads, having this in the configuration is probably the best option. 90% of the time I am not interested in kthreads for example, so this would work well for me. |
|
I think so too. Could you change to configuration? |
|
Sure! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often need to remove kthreads from the output of top/ps commands, to only check what is running in userspace.
For this reason I would like an option to filter out them.
I also prefer to print them out surrounded by square brackets to easily eyeball them when not filtered out.