Relax Rng trait bounds to allow ?Sized Rngs
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the code to compile if you pass it `&mut dyn RngType`, since trait objects are unsized. See here for an example of caller code that is simplified by this change: mobilecoinfoundation/mobilecoin#1977 (comment)
tarcieri
reviewed
Nov 15, 2022
| @@ -651,7 +651,7 @@ impl RistrettoPoint { | |||
| /// discrete log of the output point with respect to any other | |||
| /// point should be unknown. The map is applied twice and the | |||
| /// results are added, to ensure a uniform distribution. | |||
| pub fn random<R: RngCore + CryptoRng>(rng: &mut R) -> Self { | |||
| pub fn random<R: RngCore + CryptoRng + ?Sized>(rng: &mut R) -> Self { | |||
There was a problem hiding this comment.
Alternatively this could just be:
pub fn random(rng: &mut dyn CryptoRngCore) -> Self {Though this requires virtual dispatch, it dramatically simplifies the method signature while allowing trait objects.
See related discussion for the @RustCrypto projects: RustCrypto/traits#1148
|
Of all the options, I think |
|
Yeah that’s where we netted out too I think. The only difference being we switched to the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the code to compile if you pass it
&mut dyn RngType,since trait objects are unsized.
See here for an example of caller code that is simplified by this
change:
mobilecoinfoundation/mobilecoin#1977 (comment)