Update zeroize and MSRV accordingly #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Jun 20, 2022
|
@tarcieri any reason this hasn't been merged yet? |
|
I’m not a maintainer of this crate |
|
@isislovecruft would love to see this merged as this issue is blocking us from updating our dependencies |
|
@isislovecruft is there a reason why this isn't getting merged? |
|
Resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out similar to #386, but updates other relevant things.
I need this because it causes issues deep in the dependencies, my chain looks like this:
So this crate deep in dependency tree causes too many issues. I think bumping it in pre-release will not cause any issues for anyone in the ecosystem.
Closes #386, fixes #387