Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax zeroize dependency #412

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Oct 17, 2022

This PR:

  • Relaxes zeroize to ^1
  • Improves documentation about this crate's MSRV
  • Fixes the MSRV tests. Previously they were using the newest deps. But the MSRV should be calculated with respect to the oldest possible deps.

I would like to cut a release soon. According to the MSRV test, our v4.0 will not require an MSRV bump.

@rozbb rozbb requested a review from tarcieri October 17, 2022 03:02
@rozbb
Copy link
Contributor Author

rozbb commented Oct 17, 2022

Would it be better actually to do cargo hack +MSRV build --powerset? This is what the RustCrypto minimum-versions script does, which is pulled in in zeroize.

@tarcieri
Copy link
Contributor

I would still suggest bumping MSRV. Though the minimum versions will work, the default cargo resolution will not and will throw compile errors if the zeroize feature is enabled.

At least 1.56 introduces rust-version so it can surface a useful message about future MSRV incompatibilities.

@rozbb rozbb merged commit 51572da into dalek-cryptography:release/4.0 Oct 17, 2022
JakkuSakura pushed a commit to JakkuSakura/curve25519-dalek that referenced this pull request Feb 14, 2024
JakkuSakura pushed a commit to JakkuSakura/curve25519-dalek that referenced this pull request Feb 14, 2024
yihau pushed a commit to anza-xyz/curve25519-dalek that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants