Update lib.rs because of change in nightly #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building with latest rust nightlies are throwing this error.
```
error: legacy asm! syntax is no longer supported
--> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/subtle-2.2.2/src/lib.rs:150:14
|
150 | unsafe { asm!("" : "=r"(input) : "0"(input) ) }
| ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| help: replace with: `llvm_asm!
```
So I did the change. ¯\_(ツ)_/¯
|
@Ancient123 hi, thanks for the patch! Could you please rebase this branch over |
|
Rebased! |
|
Thanks for the PR! I wonder whether rather than making this change, it might be better just to drop the nightly feature entirely and only have one implementation. |
|
@hdevalence i'd defer to you to decide whether inline asm actually helps. |
Merged
|
The fix for this compilation failure is included in #70, released as 2.2.3, so a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with latest rust nightlies are throwing this error.
So I did the change. ¯_(ツ)_/¯