Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme file typo #29

Closed
roidimor opened this issue Dec 26, 2013 · 1 comment
Closed

readme file typo #29

roidimor opened this issue Dec 26, 2013 · 1 comment

Comments

@roidimor
Copy link

hey, i think there's a typo in the readme file in the "on-set-time" attribute section. it should be "data-on-set-time" instead of "date-on-set-time" (which is currently written and does not work).
dalelotts added a commit that referenced this issue Dec 27, 2013
@dalelotts
Fix issue #29
740edc0
@dalelotts
Copy link
Owner

Thanks - you can also feel free to create a PR for these types of issues.

SimeonC pushed a commit to SimeonC/angular-bootstrap-datetimepicker that referenced this issue Mar 24, 2014
Merge branch 'master' of https://github.com/dalelotts/angular-bootstr…
9d4542e 
…ap-datetimepicker

# By Dale Lotts (9) and others
# Via Dale Lotts
* 'master' of https://github.com/dalelotts/angular-bootstrap-datetimepicker:
  Add grunt karma:watch task to run tests in background while developing
  Update readme to remove reference to Idea directory
  Update readme to separate on-set-time from configuration options.
  Add weekStart option and update to latest dependency versions. Also updated demo page.
  Update README.md
  Update to latest dependency versions and add ng-show example to demo page
  Fix issue dalelotts#26 - Include css file in bower.json
  Fix issue dalelotts#29
  added weekStart option
  Update callback function when date is selected to provide old and new values. Bump version to 0.2.1
  Add a Bitdeli Badge to README

Conflicts:
	src/js/datetimepicker.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalelotts @roidimor