feat: feedback from wordfence

dalenguyen · Dec 4, 2024 · eea2d65 · eea2d65
1 parent e6ee070
commit eea2d65
Show file tree

Hide file tree

Showing 7 changed files with 29 additions and 20 deletions.
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -19,4 +19,4 @@ jobs:
           SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}
           SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
           SLUG: integrate-firebase
-          VERSION: 0.9.3
+          VERSION: 0.10.0
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## [ 0.10.0 ] - 04-04-2024
+
+- update tested version
+- feedback from wordfence
+
 ## [ 0.9.3 ] - 07-09-2024
 
 - update css wording

diff --git a/README.md b/README.md
@@ -8,9 +8,9 @@ Tags: firebase, wordpress
 
 Requires at least: 4.0.0
 
-Tested up to: 6.5.2
+Tested up to: 6.7.1
 
-Stable tag: 0.9.3
+Stable tag: 0.10.0
 
 Requires PHP: 5.2.4
 

diff --git a/includes/class.firebase-admin.php b/includes/class.firebase-admin.php
@@ -53,15 +53,15 @@ public static function load_firebase_admin_js() {
 
         wp_enqueue_script('firebase-admin', plugin_dir_url(dirname(__FILE__)) . 'js/firebase-admin.js', array('jquery'), FIREBASE_WP_VERSION, true);
         wp_localize_script('firebase-admin', 'firebaseDatabaseOptions', array(
-            'databaseType' => self::$options_database['database_type'],
-            'collections' => self::$options_database['collection_names'],
+            'databaseType' => self::$options_database['database_type'] ?? '',
+            'collections' => self::$options_database['collection_names'] ?? '',
         )
         );
         wp_localize_script('firebase-admin', 'firebaseOptions', array(
-            'apiKey' => self::$options['api_key'],
-            'authDomain' => self::$options['auth_domain'],
-            'databaseURL' => self::$options['database_url'],
-            'projectId' => self::$options['project_id'],
+            'apiKey' => self::$options['api_key'] ?? '',
+            'authDomain' => self::$options['auth_domain'] ?? '',
+            'databaseURL' => self::$options['database_url'] ?? '',
+            'projectId' => self::$options['project_id'] ?? '',
         )
         );
     }

diff --git a/includes/class.shortcodes.php b/includes/class.shortcodes.php
@@ -61,7 +61,7 @@ public static function firebase_greetings_func() {
     public static function firebase_show_func($atts, $content) {
       $class_name = "";
       if(isset($atts['class'])){
-        $class_name = $atts['class'];
+        $class_name = esc_attr($atts['class']);
       }
       $html = "";
       $html .= "<div class='firebase-show $class_name'>";
@@ -73,7 +73,7 @@ public static function firebase_show_func($atts, $content) {
     public static function firebase_show_not_login_func($atts, $content) {
       $class_name = "";
       if(isset($atts['class'])){
-        $class_name = $atts['class'];
+        $class_name = esc_attr($atts['class']);
       }
       $html = "";
       $html .= "<div class='firebase-show-when-not-login $class_name'>";
@@ -85,7 +85,7 @@ public static function firebase_show_not_login_func($atts, $content) {
     public static function firebase_login_error_func($atts) {
       $class_name = "";
       if(isset($atts['class'])){
-        $class_name = $atts['class'];
+        $class_name = esc_attr($atts['class']);
       }
       $html = "";
       $html .= "<div class='$class_name'>";
@@ -103,15 +103,15 @@ public static function realtime_func($atts) {
        $document_name = "";
 
        if(isset($atts['class'])){
-         $class_name = $atts['class'];
+         $class_name = esc_attr($atts['class']);
        }
 
        if(isset($atts['collection_name'])){
-         $collection_name = $atts['collection_name'];
+         $collection_name = esc_attr($atts['collection_name']);
        }
 
        if(isset($atts['document_name'])){
-         $document_name = $atts['document_name'];
+         $document_name = esc_attr($atts['document_name']);
        }
 
        $html = "";

diff --git a/init.php b/init.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * The initation loader for Firebase, and the main plugin file.
+ * The initiation loader for Firebase, and the main plugin file.
  *
  * @category     WordPress_Plugin
  * @package      integrate-firebase
@@ -16,7 +16,7 @@
  * Author URI:   http://dalenguyen.me
  * Contributors: Dale Nguyen (@dalenguyen)
  *
- * Version:      0.9.3
+ * Version:      0.10.0
  *
  * Text Domain:  integrate-firebase
  *
@@ -54,7 +54,7 @@
     exit;
 }
 
-define('FIREBASE_WP_VERSION', '0.9.3');
+define('FIREBASE_WP_VERSION', '0.10.0');
 define('FIREBASE_WP__MINIMUM_WP_VERSION', '4.0.0');
 define('FIREBASE_WP__PLUGIN_DIR', plugin_dir_path(__FILE__));
 

diff --git a/readme.txt b/readme.txt
@@ -3,8 +3,8 @@ Contributors:      hanthuy
 Donate link:       https://www.paypal.me/DaleNguyen
 Tags:              firebase
 Requires at least: 4.0.0
-Tested up to:      6.5.2
-Stable tag:        0.9.3
+Tested up to:      6.7.1
+Stable tag:        0.10.0
 Requires PHP:      5.2.4
 License:           GPLv2 or later
 License URI:       http://www.gnu.org/licenses/gpl-2.0.html
@@ -97,6 +97,10 @@ This is a shortcode for log out button.
 
 == Changelog ==
 
+= 0.10.0 =
+* update tested version
+* feedback from wordfence
+
 = 0.9.3 =
 * update css wording