fix parameters restoration

dalibo · Jun 29, 2023 · 5f1bdc4 · 5f1bdc4
1 parent 9bc31c8
commit 5f1bdc4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pg_query_settings.c b/pg_query_settings.c
@@ -65,7 +65,7 @@ static const char* pgqs_config ="pgqs_config";
 typedef struct parameter
 {
   char *name;
-  const char *oldValue;
+  char *oldValue;
   slist_node node;
 } parameter;
 
@@ -126,6 +126,8 @@ static void DestroyPRList(bool reset)
       SetConfigOption(param->name, param->oldValue, PGC_USERSET, PGC_S_SESSION);
     }
     slist_delete_current(&iter);
+    free(param->name);
+    free(param->oldValue);
     free(param);
   }
 }
@@ -210,10 +212,10 @@ execPlantuner(Query *parse, const char *query_st, int cursorOptions, ParamListIn
           guc_value = pstrdup(TextDatumGetCString(data));
 
           param = malloc(sizeof(parameter));
-          param->name = guc_name;
+          param->name = strdup(guc_name);
 
           /* Get and store current value for the parameter. */
-          param->oldValue = GetConfigOption(guc_name, true, false);
+          param->oldValue = strdup(GetConfigOption(guc_name, true, false));
 
           slist_push_head(&paramResetList, &param->node);