Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not check the Upgrade response Sec-WebSocket-Accept #334

Closed
hishnash opened this issue May 21, 2017 · 1 comment
Closed

Does not check the Upgrade response Sec-WebSocket-Accept #334

hishnash opened this issue May 21, 2017 · 1 comment
Labels

Comments

@hishnash
Copy link
Contributor

https://github.com/daltoniam/Starscream/blob/master/Source/WebSocket.swift#L581-L583

This should be validated as being equal:

SHA1(Sec_WebSocket_Key_Value + '258EAFA5-E914-47DA-95CA-C5AB0DC85B11')

The reason for this is to ensure that the web socket is not behind a caching layer.
see https://tools.ietf.org/html/rfc6455 page 24

@daltoniam daltoniam added the bug label May 23, 2017
@daltoniam
Copy link
Owner

Would you look at that. Can't believe I missed that. Thanks for the link. Certainly something that should be addressed. Thanks!

daltoniam added a commit that referenced this issue Jun 24, 2017
sahara108 added a commit to senagbe/Starscream that referenced this issue Jul 18, 2017
* 'master' of github.com:daltoniam/Starscream: (22 commits)
  updated podspec
  the joys of getting all the package manager to play nice
  Removed Else Clause that would sometimes give a wrong error message
  updated changelog
  updated pod spec for compression changes
  SecTrust object now is conditionally unwrapped
  spm fix
  spm fix
  package manager update
  fixes daltoniam#309, daltoniam#319, daltoniam#334
  make WSResponse values public
  Add Advanced Delegate and Custom HTTP methods
  Update README with (trite) grammar changes
  Include zlib as a module, rather than using `@_silgen_name` and redefinition.  This is less verbose and less error-prone.
  Add information about compression support to README.  Other changes based on PR feedback.
  Avoid unnecessary copying.  Confirm Autobahn fuzzing test results are comparable with the autobahn library itself.
  Fix capture memory leaks in Autobahn tester.
  Fixes to handle different windowsBits and noContextTakeover.
  Integrate compression classes.
  Add compression classes and unit tests.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants