Resolve memory leak on NativeEngine #1043
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Fixes #832 (Is there a way to 'clean up' socket connection to avoid memory leaks, before attempting to reconnect?)
Fixes #938 (Memory leak when use native engine)
Fixes #995 (if you socket resart many time,cpu is very busy and Forever and ever)
Goals ⚽
According to the Apple document,
The URLSession is retained because neither invalidateAndCancel() nor finishTasksAndInvalidate() has been called. Consequently, this leads to memory leaks after initializing a new WebSocket and establishing a connection.
Implementation Details 🚧
Invalidate the NativeEngine's URLSession at WebSocket dealloc.
Unit Test Results: Passed