Avoid doing unaligned reads/writes via UnsafePointer #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead read/write individual bytes via UnsafePointer<UInt8>. This fixes crashes that only happen when optimization is turned on, on 32 bit arm builds. Not all processors support unaligned reads/writes of 64 bit values. Without optimizations, the reads/writes probably end up handling one byte at a time (like this commit makes it do), while higher optimization levels convert it to single reads/writes of the full size, which may require that the pointer is properly aligned.
|
Should fix #77 |
|
Awesome, thank you much for fixing this. @nuclearace agreed. |
daltoniam
added a commit
that referenced
this pull request
Dec 12, 2015
Avoid doing unaligned reads/writes via UnsafePointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead read/write individual bytes via UnsafePointer.
This fixes crashes that only happen when optimization is turned on,
on 32 bit arm builds.
Not all processors support unaligned reads/writes of 64 bit values.
Without optimizations, the reads/writes probably end up handling one
byte at a time (like this commit makes it do), while higher
optimization levels convert it to single reads/writes of the full
size, which may require that the pointer is properly aligned.