Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: https://github.com/daltoniam/Starscream/issues/442 #443

Closed
wants to merge 2 commits into from
Closed

Conversation

BlakeBarrett
Copy link
Contributor

Should build again under Swift 3.2

Should build again under Swift 3.2
This doesn't need to effect anyone else' code.
@BlakeBarrett
Copy link
Contributor Author

Alternatively, you could do conditional compilation.

#if swift(>=4)
#else
    fileprivate extension String {
        var count: Int {
            return self.characters.count
        }
    }
#endif

@daltoniam
Copy link
Owner

Thanks! I had another branch going with some other fixes so I just pulled this code into version 3.0.4 which I just released! Thanks again.

@daltoniam daltoniam closed this Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants