Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode/v2.1.0 #47

Merged
merged 5 commits into from
Oct 15, 2021
Merged

vscode/v2.1.0 #47

merged 5 commits into from
Oct 15, 2021

Conversation

daltonmenezes
Copy link
Owner

This PR:

  • Adds colors to editor inlay hint
  • Updates selection color to accent20
  • Updates JSX children texts to be green

@daltonmenezes daltonmenezes self-assigned this Oct 15, 2021
@daltonmenezes daltonmenezes merged commit 2078d97 into main Oct 15, 2021
@daltonmenezes daltonmenezes deleted the vscode/v2.1.0 branch October 15, 2021 00:17
@zaneshaw
Copy link

Can I open a PR to revert the changes made to JSX text? There's no contrast to attributes and it's also inconsistent with HTML text.

Current HTML styling:
image

Current JSX styling:
image

@zaneshaw zaneshaw mentioned this pull request Sep 27, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daltonmenezes daltonmenezes

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daltonmenezes @zaneshaw