fix: Remove trailing whitespace character when exporting My List - Closes #4 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yuanLeeMidori thanks for the PRs. I'm testing and trying to figure out if this new blank line spaces are expected by you. |
|
Thank you for reviewing my code. No, it is not expected. I've tested this Please let me know if the issue is still there in my PR, thank you. |
|
@yuanLeeMidori I'm going to merge this one, but the issue was in the #6 PR, so I reverted that merge. Can you check the #6 please? |
|
Sure. I'll send a new PR for solving issue #5 with no new line in the beginning. Thank you for pointing it out. |
daltonmenezes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this commit should fix issue #4. The trailing spaces should be removed from the exported list. Please let me know if there is anything I can improve, thank you.