Prefer SetItem over Add for ImmutableDictionary (#919)

This handles the odd case where an item already exists in the dictionary - it's just safer this way.
dalyIsaac · Jun 28, 2024 · 49a78b0 · 49a78b0
1 parent 2f6dc23
commit 49a78b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Whim.Tests/Store/WorkspaceSector/WorkspacePickersTests.cs b/src/Whim.Tests/Store/WorkspaceSector/WorkspacePickersTests.cs
@@ -261,7 +261,7 @@ private static IWindow Setup_WindowPosition(IContext ctx, MutableRootSector root
 
 		workspace = workspace with
 		{
-			WindowPositions = workspace.WindowPositions.Add(
+			WindowPositions = workspace.WindowPositions.SetItem(
 				window.Handle,
 				new WindowPosition(WindowSize.Minimized, new Rectangle<int>())
 			)

diff --git a/src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransform.cs b/src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransform.cs
@@ -34,7 +34,7 @@ IWindow window
 			? workspace
 			: workspace with
 			{
-				WindowPositions = workspace.WindowPositions.Add(window.Handle, new WindowPosition()),
+				WindowPositions = workspace.WindowPositions.SetItem(window.Handle, new WindowPosition()),
 
 				// Restore in just the active layout engine. MinimizeWindowEnd is not called as part of
 				// Whim starting up.

diff --git a/src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowStartTransform.cs b/src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowStartTransform.cs
@@ -41,7 +41,7 @@ IWindow window
 
 		workspace = workspace with
 		{
-			WindowPositions = workspace.WindowPositions.Add(window.Handle, new WindowPosition())
+			WindowPositions = workspace.WindowPositions.SetItem(window.Handle, new WindowPosition())
 		};
 
 		for (int idx = 0; idx < workspace.LayoutEngines.Count; idx++)