Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remaining [Next|Previous] method pairs? #734

Closed
urob opened this issue Dec 21, 2023 · 1 comment
Closed

Refactor remaining [Next|Previous] method pairs? #734

urob opened this issue Dec 21, 2023 · 1 comment
Labels
enhancement New feature or request refactor The code can be simplified/moved/cleaned up

Comments

@urob
Copy link
Contributor

urob commented Dec 21, 2023 •
edited
Loading

Just did a quick pattern search to identify the remaining Next/Previous method pairs. These two would fit the Adjacent pattern well:

  • WorkspaceManager.MoveWindowTo[Next|Previous]Monitor
  • MonitorManager.Get[Next|Previous]Monitor

This one also lends itself to a merge, but the Adjacent naming seems slightly less fitting:

  • Workspace.[Next|Previous]LayoutEngine
@urob urob added the enhancement New feature or request label Dec 21, 2023
@dalyIsaac dalyIsaac added the refactor The code can be simplified/moved/cleaned up label Dec 25, 2023
dalyIsaac added a commit that referenced this issue May 5, 2024
@dalyIsaac
Create GetAdjacentMonitorPicker (see #734)
c58511b
@dalyIsaac
Copy link
Owner

dalyIsaac commented Jun 29, 2024 •
edited
Loading

Will be replaced with the updated structure from #889.

@github-project-automation github-project-automation bot moved this to Done in Whim Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor The code can be simplified/moved/cleaned up
Projects
Whim
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@urob @dalyIsaac