Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate FocusIndicator flickering #918

Closed
dalyIsaac opened this issue Jun 27, 2024 · 4 comments · Fixed by #922
Closed

Investigate FocusIndicator flickering #918

dalyIsaac opened this issue Jun 27, 2024 · 4 comments · Fixed by #922
Labels
bug Something isn't working focus indicator Whim.FocusIndicator

Comments

@dalyIsaac
Copy link
Owner

No description provided.

@dalyIsaac dalyIsaac added this to Whim Jun 27, 2024
@dalyIsaac dalyIsaac converted this from a draft issue Jun 27, 2024
@dalyIsaac dalyIsaac added focus indicator Whim.FocusIndicator bug Something isn't working labels Jun 27, 2024
@urob
Copy link
Contributor

urob commented Jun 27, 2024

Adding a screencast and some logs:

Recording.2024-06-27.102738.mp4

The logs below start right after I changed to workspace 1 on my primary monitor (DISPLAY). For the entire duration, workspace 2 was active (but unfocused) on my other monitor (DISPLAY1). Interestingly, even though workspace 2 was never focused, the logs are full of events about workspace 2.

I apologize for the logs being enormous. I wanted to include the entire history since focusing workspace 1. But if you focus on just the last few seconds from, say, 10:23:45:000 to the end 10:23:51.604 there were plenty of flickering events throughout that window.

EDIT: The file was just too massive, so I truncated it to the last 8 seconds. Let me know if there's anything else that would be useful.

flicker.log

@urob
Copy link
Contributor

urob commented Jun 27, 2024

Let me add that this also occurs with the default config. It usually takes a few minutes to start and seems to require windows open on multiple workspaces/monitors (I haven't pinned down the exact conditions). But once it starts, it stays (always affecting the currently focused window regardless on which workspace/monitor) and even seems to get progressively worse to the point where the border disappears for most of the time and only occasionally flickers back on.

@urob
Copy link
Contributor

urob commented Jun 27, 2024

One more observation:

Keeping things running for a while, it seems that the flicker (or whatever causes it) ended up freezing whim eventually. That is, it would no longer respond to keybinds or interacting with the status bar via the mouse.

@dalyIsaac dalyIsaac linked a pull request Jun 29, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Whim Jun 29, 2024
@dalyIsaac
Copy link
Owner Author

I've resolved the flickering - that was a nice simple fix. I'll fix the logs being too verbose later. I think I've seen that freeze - my hunch is that it's separate to this, I'm keeping an eye out for it.

@urob urob mentioned this issue Jul 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working focus indicator Whim.FocusIndicator
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants