Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent additional layouts when focusing a window #922

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Jun 29, 2024

Setting the LastFocusedWindowHandle for a workspace would previously trigger a layout, which would trigger the FocusIndicatorPlugin to flicker.

SetLastFocusedWindowTransform now no longer triggers a layout operation.

@dalyIsaac dalyIsaac added bug Something isn't working core Whim labels Jun 29, 2024
@dalyIsaac dalyIsaac linked an issue Jun 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (2c68047) to head (d33e463).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files         271      271           
  Lines       11264    11264           
  Branches     1262     1262           
=======================================
+ Hits         9097     9098    +1     
  Misses       1995     1995           
+ Partials      172      171    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review June 29, 2024 10:52
@dalyIsaac dalyIsaac merged commit 67ea525 into main Jun 29, 2024
10 checks passed
@dalyIsaac dalyIsaac deleted the 918-investigate-focusindicator-flickering branch June 29, 2024 10:54
@urob urob mentioned this pull request Jul 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate FocusIndicator flickering
1 participant