Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivateAdjacent ignores skipActive #953

Closed
urob opened this issue Jul 10, 2024 · 0 comments · Fixed by #954
Closed

ActivateAdjacent ignores skipActive #953

urob opened this issue Jul 10, 2024 · 0 comments · Fixed by #954
Labels
bug Something isn't working triage Untriaged issues

Comments

@urob
Copy link
Contributor

urob commented Jul 10, 2024 •
edited
Loading

Behavior

One of the recent versions (not sure which exactly) introduced a new bug, where the skipActive argument to ActivateAdjacent and MoveWindowToAdjacentWorkspace no longer seem to work. That is, calling

Butler.ActivateAdjacent(skipActive: true)

will activate the next workspace, even if it is active on another monitor, resulting in the two workspaces being swapped.

Similar, calling

Butler.MoveWindowToAdjacentWorkspace(skipActive: true)

will move a window to the next workspace, even if that is active on another monitor.

Config

https://github.com/urob/whim-config
@urob urob added bug Something isn't working triage Untriaged issues labels Jul 10, 2024
@urob urob changed the title ActivateAdjacent ignored skipActive ActivateAdjacent ignores skipActive Jul 10, 2024
@dalyIsaac dalyIsaac moved this to In progress in Whim Jul 13, 2024
@dalyIsaac dalyIsaac linked a pull request Jul 13, 2024 that will close this issue
ActivateAdjacent now skips all active workspaces #954
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Whim Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Untriaged issues
Projects
Whim
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ActivateAdjacent now skips all active workspaces dalyIsaac/Whim
1 participant
@urob