Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivateAdjacent now skips all active workspaces #954

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Jul 13, 2024

Previously, PickAdjacentWorkspace only took into account the workspace which is on the active monitor. This has been changed to account for all workspaces which appear on a monitor.

@dalyIsaac dalyIsaac added bug Something isn't working core Whim labels Jul 13, 2024
@dalyIsaac dalyIsaac linked an issue Jul 13, 2024 that may be closed by this pull request
@dalyIsaac dalyIsaac marked this pull request as ready for review July 13, 2024 06:54
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (8446a66) to head (024bd74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   80.91%   80.92%           
=======================================
  Files         272      272           
  Lines       11438    11442    +4     
  Branches     1280     1280           
=======================================
+ Hits         9255     9259    +4     
  Misses       2010     2010           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac changed the title ActivateAdjacent now skips _all_ active workspaces ActivateAdjacent now skips all active workspaces Jul 13, 2024
@dalyIsaac dalyIsaac merged commit 185ade1 into main Jul 13, 2024
10 checks passed
@dalyIsaac dalyIsaac deleted the 953-activateadjacent-ignores-skipactive branch July 13, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivateAdjacent ignores skipActive
1 participant