Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonitorSector #894

Merged
merged 36 commits into from
May 14, 2024
Merged

Add MonitorSector #894

merged 36 commits into from
May 14, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented May 13, 2024

The MonitorManager no longer stores or directly interacts with monitors. Instead, the monitor manager now calls pickers and transforms for the MonitorSector of the Store.

@dalyIsaac dalyIsaac added enhancement New feature or request refactor The code can be simplified/moved/cleaned up labels May 13, 2024
@dalyIsaac dalyIsaac linked an issue May 13, 2024 that may be closed by this pull request
10 tasks
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 81.60%. Comparing base (bb77d9c) to head (6129384).

Files Patch % Lines
src/Whim.TestUtils/Assert.cs 76.78% 11 Missing and 2 partials ⚠️
src/Whim/Butler/ButlerEventHandlers.cs 94.70% 7 Missing and 2 partials ⚠️
src/Whim/Butler/ButlerChores.cs 97.66% 3 Missing and 3 partials ⚠️
...im.Bar/ActiveLayout/ActiveLayoutWidgetViewModel.cs 91.17% 2 Missing and 1 partial ⚠️
src/Whim.TestUtils/MonitorTestUtils.cs 94.33% 2 Missing and 1 partial ⚠️
src/Whim.Bar/Workspace/WorkspaceWidgetViewModel.cs 96.92% 0 Missing and 2 partials ⚠️
....Bar/FocusedWindow/FocusedWindowWidgetViewModel.cs 97.72% 0 Missing and 1 partial ⚠️
src/Whim/Context/Context.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   80.81%   81.60%   +0.79%     
==========================================
  Files         206      219      +13     
  Lines       10251    10455     +204     
  Branches     1148     1175      +27     
==========================================
+ Hits         8284     8532     +248     
+ Misses       1851     1801      -50     
- Partials      116      122       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review May 14, 2024 10:26
@dalyIsaac dalyIsaac merged commit b20b75a into main May 14, 2024
7 checks passed
@dalyIsaac dalyIsaac deleted the 893-monitorsector branch May 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MonitorSector
1 participant