Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer Store initialization to after other managers #905

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented May 28, 2024

Previously the Store would initialize prior to the other managers. As a result:

  1. the triggered MonitorsChangedTransform would trigger the ButlerEventHandlers.OnMonitorsChanged.
  2. ButlerEventHandlers.OnMonitorsChanged would create workspaces as (at that time) no workspaces existed.

Now, Store initializes after all the other managers.

This is a temporary fix as the migration to the Store continues (#889).

@dalyIsaac dalyIsaac added bug Something isn't working core Whim labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.62%. Comparing base (11d09d3) to head (37464c5).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Whim/Context/Context.cs 0.00% 2 Missing ⚠️
src/Whim.Bar/BarPlugin.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   81.62%   81.62%           
=======================================
  Files         219      219           
  Lines       10463    10463           
  Branches     1176     1176           
=======================================
  Hits         8540     8540           
  Misses       1801     1801           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review May 28, 2024 10:50
@dalyIsaac dalyIsaac merged commit 22e30b0 into main May 28, 2024
5 of 6 checks passed
@dalyIsaac dalyIsaac deleted the workspaces-fix branch May 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant