Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to Store calls #915

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add logging to Store calls #915

merged 1 commit into from
Jun 27, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Jun 27, 2024

Improve traceability of the sector data store by adding logs for each Transform and Picker.

@dalyIsaac dalyIsaac added enhancement New feature or request core Whim labels Jun 27, 2024
@dalyIsaac dalyIsaac linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.69%. Comparing base (b06e7c7) to head (ff353d4).

Files Patch % Lines
src/Whim/Store/Store.cs 62.50% 3 Missing ⚠️
src/Whim/Context/CoreSavedStateManager.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   80.70%   80.69%   -0.01%     
==========================================
  Files         271      271              
  Lines       11216    11227      +11     
  Branches     1258     1258              
==========================================
+ Hits         9052     9060       +8     
- Misses       1992     1995       +3     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review June 27, 2024 10:58
@dalyIsaac dalyIsaac merged commit 1ac3bab into main Jun 27, 2024
9 of 10 checks passed
@dalyIsaac dalyIsaac deleted the 914-logging-in-store branch June 27, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging in Store
1 participant