Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer SetItem over Add for ImmutableDictionary #919

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Prefer SetItem over Add for ImmutableDictionary #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Whim.Tests/Store/WorkspaceSector/WorkspacePickersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ private static IWindow Setup_WindowPosition(IContext ctx, MutableRootSector root

workspace = workspace with
{
WindowPositions = workspace.WindowPositions.Add(
WindowPositions = workspace.WindowPositions.SetItem(
window.Handle,
new WindowPosition(WindowSize.Minimized, new Rectangle<int>())
)
Expand Down
2 changes: 1 addition & 1 deletion src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ IWindow window
? workspace
: workspace with
{
WindowPositions = workspace.WindowPositions.Add(window.Handle, new WindowPosition()),
WindowPositions = workspace.WindowPositions.SetItem(window.Handle, new WindowPosition()),

// Restore in just the active layout engine. MinimizeWindowEnd is not called as part of
// Whim starting up.
Expand Down
2 changes: 1 addition & 1 deletion src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowStartTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ IWindow window

workspace = workspace with
{
WindowPositions = workspace.WindowPositions.Add(window.Handle, new WindowPosition())
WindowPositions = workspace.WindowPositions.SetItem(window.Handle, new WindowPosition())
};

for (int idx = 0; idx < workspace.LayoutEngines.Count; idx++)
Expand Down
Loading