Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when monitors change #921

Merged

Conversation

dalyIsaac
Copy link
Owner

Replace the stored PrimaryMonitorHandle, ActiveMonitorHandle, and LastWhimActiveMonitorHandlewhen the monitors are changed.HMONITOR`s can change as monitors change.

@dalyIsaac dalyIsaac added bug Something isn't working core Whim labels Jun 28, 2024
@dalyIsaac dalyIsaac linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (49a78b0) to head (32f7c8b).

Files Patch % Lines
src/Whim.TestUtils/MonitorTestUtils.cs 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   80.71%   80.76%   +0.05%     
==========================================
  Files         271      271              
  Lines       11234    11264      +30     
  Branches     1258     1262       +4     
==========================================
+ Hits         9067     9097      +30     
  Misses       1995     1995              
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review June 28, 2024 22:15
@dalyIsaac dalyIsaac merged commit 2c68047 into main Jun 28, 2024
9 checks passed
@dalyIsaac dalyIsaac deleted the 920-monitor-handles-arent-replaced-after-monitors-change branch June 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor handles aren't replaced after monitors change
1 participant