Don't apply custom Firefox processing on startup #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
+ Coverage 81.01% 81.03% +0.01%
==========================================
Files 274 274
Lines 11496 11503 +7
Branches 1290 1291 +1
==========================================
+ Hits 9314 9321 +7
Misses 2008 2008
Partials 174 174 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#957 introduced custom logic to handle Firefox starting while Whim was running. However, this logic is unnecessary if Firefox is started prior to Whim.
This PR introduces
IWindowSector.StartupWindowto store the windows which were open when Whim started. If the Firefox window is in this set, then the custom logic is not needed and all events are processed as normal.