This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
NLog MDLC + NDLC when NLog ver. 4.6 is ready #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2018
|
Thanks for PR @snakefoot ! I see nlog 4.6 is not shipped yet. This is safe to ship before 4.6 is out? |
|
@snakefoot Can you contact me privately (see my profile for email)? I would like some help maintaining this library and I feel I am doing a disservice to you and the lib's users at this point. Simple reason is time. Am @RandomPunter on twitter too if you want to DM there. Cheers. |
|
Yes the reflection logic will ensure the new logic will only activate when running with NLog 4.6
I'm already fully booked with NLog so not ready for an extra child :)
|
|
Should one also update the pp-file? Looks like I have forgotten it. Will fix it tonight. Unless you do it
|
Understood! thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLog 4.6 includes better handling of non-string-objects: NLog/NLog#2857
There might be a catch22 when having multiple libraries that are using LibLog and only some are using 5.0.3.Then use of OpenMdc will behave different during transition phase of upgrading all libraries. But MDLC is the "future". One can avoid the catch22 by not upgrading the main application to NLog 4.6 until all libraries are updated (If they actually make use of OpenMdc, which seems rare)