Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The manager is not able to handle non-existent robot files. #241

Closed
ArekKuczynski opened this issue May 16, 2024 · 2 comments
Closed

The manager is not able to handle non-existent robot files. #241

ArekKuczynski opened this issue May 16, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request Manager Issue Affects the Manager
Milestone
v1.3.1

Comments

@ArekKuczynski
Copy link
Collaborator

ArekKuczynski commented May 16, 2024 •
edited
Loading

Describe the bug
When you have a scenario file with some robot files, but the Manager cannot find them, the Manager will crash.

To Reproduce
Steps to reproduce the behavior:

  1. Open Manager
  2. Save a scenario file with example robot file.
  3. Close Manager
  4. Delete or move the robot file
  5. Open Manager
  6. See error

Expected behavior
Manager should handle this with a special message that rejects the scenario file and tells which files are not there. For now, if you want to repair Manager you need to delete the RFSwarmManager.ini and reopen the Manager.

Screenshots
image
image
image

Additional context
test.rfs file:

[Scenario]
uploadmode = err
scriptcount = 1
graphlist = 

[1]
robots = 10
delay = 10
rampup = 10
run = 10
test = Example Test Case
script = i_dont_exist.robot
@ArekKuczynski ArekKuczynski added enhancement New feature or request Manager Issue Affects the Manager potential bug Might be a bug, requires further clarification labels May 16, 2024
@damies13
Copy link
Owner

I agree this is a bug 👍

@damies13 damies13 added bug Something isn't working and removed potential bug Might be a bug, requires further clarification labels May 16, 2024
@damies13 damies13 added this to the v1.3.1 milestone May 17, 2024
ArekKuczynski added a commit to NiceProjectPoland/rfswarm that referenced this issue May 23, 2024
@ArekKuczynski
Started making Bugfix and Test for Issue damies13#241
b0a6e9f
ArekKuczynski added a commit to NiceProjectPoland/rfswarm that referenced this issue May 23, 2024
@ArekKuczynski
Small corrections to Test damies13#241 and make Super-Linter happy
51d898f
ArekKuczynski added a commit to NiceProjectPoland/rfswarm that referenced this issue May 24, 2024
@ArekKuczynski
Fix for bug-fix Issue damies13#241
6c032f0
ArekKuczynski added a commit to NiceProjectPoland/rfswarm that referenced this issue May 24, 2024
@ArekKuczynski
Improved Test Case for Issue damies13#241
4779029
@ArekKuczynski ArekKuczynski mentioned this issue May 26, 2024
Merged
damies13 added a commit that referenced this issue May 27, 2024
@damies13
Merge pull request #243 from NiceProjectPoland/Bug-fix-for-Issue-#241
a7ace36 
Bug fix and test case for Issue #241- The manager is not able to handle non-existent robot files.
@damies13
Copy link
Owner

Merged changes fixed this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request Manager Issue Affects the Manager
Projects
None yet
Milestone
v1.3.1
Development

No branches or pull requests
2 participants
@damies13 @ArekKuczynski