Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario Files use local path for scripts should be relative path #54

Closed
damies13 opened this issue Jan 6, 2020 · 0 comments
Closed

Scenario Files use local path for scripts should be relative path #54

damies13 opened this issue Jan 6, 2020 · 0 comments
Labels
bug Something isn't working Manager Issue Affects the Manager
Milestone
v0.5.2

Comments

@damies13
Copy link
Owner

damies13 commented Jan 6, 2020

Describe the bug

The scenario files use the local path (non relative / full path) to the scripts (.robot) files, when opening these scenarios on another computer (esp. if the OS is different) the scenario will not load the script files correctly.

To Reproduce
Steps to reproduce the behavior:

  1. In rfswarm create a scenario with at least 1 .robot script
  2. Save the scenario
  3. edit the scenario file (.rfs) and check the script = lines

Expected behavior
Path to the script should be relative to the .rfs file

Additional context
When opening these scenarios on another computer (esp. if the OS is different) the scenario will not load the script files correctly.
@damies13 damies13 added the potential bug Might be a bug, requires further clarification label Jan 6, 2020
@damies13 damies13 added this to the v0.5.2 milestone Jan 6, 2020
@damies13 damies13 added bug Something isn't working Manager Issue Affects the Manager and removed potential bug Might be a bug, requires further clarification labels Jan 6, 2020
damies13 added a commit that referenced this issue Jan 8, 2020
@damies13
Scenario Files, relative path for scripts - #54
5fa6df1 
Scenario Files use local path for scripts should be relative path - Issue #54
- on open checks if the file path is relative or absolute, if relative figures out the absolute path
- on save determines relative paths and saves with the relative path
- if file opened with absolute path (old scenario file) and then saved the saved scenario will be updated with relative paths
- if scenario is saved as new scenario file name (e.g. in a different path) then the new relative paths are calculated and new file will have the adjusted relative paths to the new file.
- plus no longer crash when scenario file no longer exists
@damies13 damies13 closed this as completed Jan 8, 2020
damies13 added a commit that referenced this issue Jul 27, 2024
@damies13
Merge pull request #267 from NiceProjectPoland/Test-#201-for-Issue-#54
8553e71 
Test Case for Issue #54 - Verify the files referenced in the scenario are all using relative paths.
Issue #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Manager Issue Affects the Manager
Projects
None yet
Milestone
v0.5.2
Development

No branches or pull requests
1 participant
@damies13