-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large size media file does not load, or causes Damus crash #1059
Comments
note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376 |
Consistent with other clients, can these images be progressively downloaded or display a loader animation? Amethyst, Snort, Nostur all display it. https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376 |
@robagreda WDYT 👀 |
Specifically I am interested in the user interface of letting a client know media is loading, or is not supported (e.g. due to max file size). @jb55 mentions Damus does not have CDN, while clients like Snort do currently. Related: low data & cellular mode #919 |
Perhaps add a warning if an oversized image isn't loading and allow the
user to tap to download it. Would that work?
|
There's a couple things going on.
|
Notes https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376 Do not render media. Did not experience crash. |
we don't load > 20MB for sanity ... ideally we would detect content size and force a proxy for larger images |
what happens
50MB image does not load, or causes Damus to crash
SerSleepy:
NoteID
Https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h
The text was updated successfully, but these errors were encountered: