Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large size media file does not load, or causes Damus crash #1059

Open
alltheseas opened this issue May 1, 2023 · 8 comments
Open

Large size media file does not load, or causes Damus crash #1059

alltheseas opened this issue May 1, 2023 · 8 comments
Labels
bug Something is not working, or not working as intended design Design exploration & definition is required unexpected

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented May 1, 2023

what happens
50MB image does not load, or causes Damus to crash

SerSleepy:
NoteID

Https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h

@alltheseas alltheseas added bug Something is not working, or not working as intended unexpected labels Nov 13, 2023
@alltheseas
Copy link
Collaborator Author

note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@dmnyc
Copy link

dmnyc commented Nov 13, 2023

Consistent with other clients, can these images be progressively downloaded or display a loader animation?

Amethyst, Snort, Nostur all display it.

https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@alltheseas
Copy link
Collaborator Author

Consistent with other clients, can these images be progressively downloaded or display a loader animation?

Amethyst, Snort, Nostur all display it.

https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@robagreda WDYT 👀

@alltheseas alltheseas added the design Design exploration & definition is required label Nov 13, 2023
@alltheseas
Copy link
Collaborator Author

Consistent with other clients, can these images be progressively downloaded or display a loader animation?
Amethyst, Snort, Nostur all display it.
https://snort.social/e/note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

@robagreda WDYT 👀

Specifically I am interested in the user interface of letting a client know media is loading, or is not supported (e.g. due to max file size).

@jb55 mentions Damus does not have CDN, while clients like Snort do currently.

Related: low data & cellular mode #919

@alltheseas alltheseas changed the title Large image does not load, or causes Damus crash [bug] Large image does not load, or causes Damus crash Nov 13, 2023
@alltheseas alltheseas changed the title Large image does not load, or causes Damus crash Large media file does not load, or causes Damus crash Nov 13, 2023
@dmnyc
Copy link

dmnyc commented Nov 13, 2023 via email

@alltheseas
Copy link
Collaborator Author

Perhaps add a warning if an oversized image isn't loading and allow the user to tap to download it. Would that work?

There's a couple things going on.

  1. Currently Damus has a limitation on file size. How might we communicate this @robagreda user is attempting loading a file size larger than the limit?
  2. Loading large file - should, and how might we communicate this @robagreda ? Could this UI extend to all media, not just "large" media?

@alltheseas
Copy link
Collaborator Author

alltheseas commented Feb 12, 2024

Notes

https://damus.io/note1fs24w4rktgwktxptu9pnpds6f92h9cygsxt3hmwtx8vwdkzgdm5q9d3m2h

note1vfsyna2svseu88rnykxnd50ml26hwrp4wpju8vu7p39yqh5dpq0s4ct376

Do not render media. Did not experience crash.

@alltheseas alltheseas moved this to Backlog in Damus Roadmap 🛣️ May 7, 2024
@alltheseas alltheseas changed the title Large media file does not load, or causes Damus crash Large size media file does not load, or causes Damus crash May 7, 2024
@jb55
Copy link
Collaborator

jb55 commented Sep 27, 2024

we don't load > 20MB for sanity ... ideally we would detect content size and force a proxy for larger images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working, or not working as intended design Design exploration & definition is required unexpected
Projects
Status: Backlog
Development

No branches or pull requests

3 participants