Relay stats window #622
Open
Relay stats window #622
+522
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why viewport instead of a floating window? it's nice to have these tools on mobile as well, and I'm not sure how the viewport thing would work there. Our profiler is implemented as a floating window |
true. should i also use a cargo feature like the profiler? that way it would stay a dev tool, not one a regular user has access to |
|
On Mon, Dec 30, 2024 at 01:45:24PM GMT, kernelkind wrote:
> Why viewport instead of a floating window? it's nice to have these tools on mobile as well, and I'm not sure how the viewport thing would work there. Our profiler is implemented as a floating window
true. should i also use a cargo feature like the profiler? that way it would stay a dev tool, not one a regular user has access to
it doesn't need to be, could just be a cli argument.
|
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional window for viewing statistics and logs for relays. This will be helpful for creating a more sophisticated subscription manager.
Closes #594