Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattening Tweaks #213

Merged
merged 14 commits into from
Jan 5, 2024
Merged

Flattening Tweaks #213

merged 14 commits into from
Jan 5, 2024

Conversation

dan-fritchman
Copy link
Owner

Follow-up on (or maybe commits to extend) #90

@dan-fritchman dan-fritchman mentioned this pull request Dec 18, 2023
3 tasks
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (831e8d3) 87.36% compared to head (9a72451) 87.49%.

Files Patch % Lines
hdl21/flatten.py 86.02% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   87.36%   87.49%   +0.12%     
==========================================
  Files         107      109       +2     
  Lines        9784     9963     +179     
==========================================
+ Hits         8548     8717     +169     
- Misses       1236     1246      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uduse uduse self-requested a review December 24, 2023 06:15
Copy link
Collaborator

@uduse uduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for helping :))

@uduse
Copy link
Collaborator

uduse commented Jan 5, 2024

Let's merge this? @dan-fritchman

@uduse uduse merged commit 9a72451 into main Jan 5, 2024
44 checks passed
@uduse uduse deleted the flatten1 branch January 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants